Fix duplicate tournament stat entries #572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hburn7
added
bug
They are variable between runs because they take a total rating delta over all matches played. They need to be truncated before each ratings processor run |
|
Okay will implement that on the processor and probably close this then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When re-running the processor/dataworker flow multiple times, tournament stats will be generated and attempted to be inserted multiple times. This PR adds a check to skip adding new tournament stats if they already exist for the player, for the current tournament.
Depends on:
@myssto can you confirm if this is a safe implementation? I think so because tournament stats don't seem to be variable between runs.