Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new constants for initial ratings #25

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Add new constants for initial ratings #25

merged 7 commits into from
Feb 20, 2024

Conversation

hburn7
Copy link
Collaborator

@hburn7 hburn7 commented Feb 16, 2024 •
edited
Loading

Closes #11

@hburn7 hburn7 requested review from 486c and cytusine0 February 16, 2024 23:27
@hburn7 hburn7 self-assigned this Feb 16, 2024
@hburn7 hburn7 requested a review from Chiffario February 16, 2024 23:36
cytusine0
cytusine0 requested changes Feb 17, 2024
View reviewed changes
Copy link
Contributor

@cytusine0 cytusine0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still learning how this all works 🤠

super small edits plus a general question about how we're dealing with different gamemodes

@hburn7 hburn7 requested a review from cytusine0 February 17, 2024 02:09
@hburn7
Copy link
Collaborator Author

hburn7 commented Feb 17, 2024

Opted to use OSU_ as the prefix for the mode-specific rating constants as that is the official term for osu!Standard.

Chiffario
Chiffario approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@Chiffario Chiffario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, don't see a better way to handle this atm

cytusine0
cytusine0 requested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@cytusine0 cytusine0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of small edits!

@hburn7 hburn7 requested a review from cytusine0 February 20, 2024 23:16
cytusine0
cytusine0 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@cytusine0 cytusine0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@hburn7 hburn7 removed the request for review from 486c February 20, 2024 23:42
@hburn7 hburn7 merged commit 36e2079 into master Feb 20, 2024
2 of 3 checks passed
@hburn7 hburn7 deleted the hotfix/multi-reference branch February 20, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chiffario Chiffario Chiffario approved these changes

@cytusine0 cytusine0 cytusine0 approved these changes

Assignees

@hburn7 hburn7

Labels
size/S type:code-quality
Projects
No open projects
o!TR Beta Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set decay minimum as function of multiplier
3 participants
@hburn7 @Chiffario @cytusine0