Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GameWinRecord, MatchWinRecord, and PlayerMatchStats generation #45

Merged
merged 10 commits into from
May 11, 2024

Conversation

hburn7
Copy link
Collaborator

@hburn7 hburn7 commented May 7, 2024

Closes #9

@hburn7 hburn7 added area:statistics epic Very large feature/task potentially covering several areas of the program labels May 7, 2024
@hburn7 hburn7 requested a review from Chiffario May 7, 2024 22:00
@hburn7 hburn7 self-assigned this May 7, 2024
@hburn7 hburn7 requested a review from 486c May 11, 2024 19:50
Copy link
Contributor

@Chiffario Chiffario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM for an initial version, concerns have been commented on but they all should be relatively minor for now

@hburn7 hburn7 merged commit 588aac8 into master May 11, 2024
2 of 3 checks passed
@hburn7 hburn7 deleted the feature/game-win-record-populated branch May 11, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:statistics epic Very large feature/task potentially covering several areas of the program size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statistics framework
3 participants