Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ABSOLUTE_RATING_FLOOR, DEFAULT_VOLATILITY as limits for rating and volatility #82

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Use ABSOLUTE_RATING_FLOOR, DEFAULT_VOLATILITY as limits for rating and volatility #82

merged 5 commits into from
Dec 19, 2024

Conversation

hburn7
Copy link
Collaborator

@hburn7 hburn7 commented Dec 19, 2024

  • Rating can no longer fall below the defined minimum.
  • Volatility can no longer exceed the default.

Added tests for these.

Closes #81

@hburn7 hburn7 added bug Something isn't working area:rating labels Dec 19, 2024
@hburn7 hburn7 requested a review from SourMongoose December 19, 2024 04:47
@hburn7 hburn7 merged commit c5ad872 into master Dec 19, 2024
3 checks passed
@hburn7 hburn7 deleted the hotfix/min-rating branch December 19, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SourMongoose SourMongoose SourMongoose approved these changes

Assignees
No one assigned
Labels
area:rating bug Something isn't working size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Absolute rating floor not implemented
2 participants
@hburn7 @SourMongoose