Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite decay #88

Merged
merged 7 commits into from
Jan 6, 2025
Merged

rewrite decay #88

merged 7 commits into from
Jan 6, 2025

Conversation

hburn7
Copy link
Collaborator

@hburn7 hburn7 commented Dec 28, 2024

Closes #87, #85

Changes:

  • Fixed bug where decay would not begin at the correct time.
  • Fixed issue where the initial rating adjustment was set to a very old default time. Now, it is set to the time of the first match's start time minus one second.
  • Fixed issue where initial rating adjustments for rulesets were created even though players had no matches for that ruleset.
  • Refactored the decay codebase to be more robust and testable
  • Fixed bug where players would see no real-time inactivity decay
  • Removed unused crates
  • Added more processing print statements
  • Changed DECAY_DAYS to 121

Screenshots:

No initial rating for other rulesets:

  • image

Decay now extends to present time (Vaxei):

  • image

@hburn7 hburn7 added the bug Something isn't working label Dec 28, 2024
@hburn7 hburn7 requested a review from SourMongoose December 28, 2024 14:11
@hburn7 hburn7 requested a review from SourMongoose January 6, 2025 21:32
@hburn7 hburn7 changed the title fix decay timestamps rewrite decay Jan 6, 2025
@hburn7 hburn7 requested a review from SourMongoose January 6, 2025 23:41
@hburn7 hburn7 merged commit 77d5bf9 into master Jan 6, 2025
3 checks passed
@hburn7 hburn7 deleted the hotfix/decay-timestamps branch January 6, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decay adjustment timestamps are inaccurate
2 participants