feat(guidelines): add new guideline for money fields #89

JanMeier1337 · 2025-04-30T11:49:36Z

Changelog:

New

SHOULD use common otto:decimal format R100079
SHOULD use common otto:money object R100080

jensfischer1515 · 2025-04-30T11:53:57Z

closes #29

jensfischer1515 · 2025-04-30T12:02:59Z

we would like to try to move the "Reasoning" part into a separate Architecture Decision Record and would like to get support for this.

...delines/global/json/canonical-data-types/rules/should-use-common-format-for-money-amounts.md

maxedenharter0507

Good starting point, thank you! Let's discuss some points :-)

...delines/global/json/canonical-data-types/rules/should-use-common-format-for-money-amounts.md

dev-context/global/should-use-common-format-for-money-amounts.md

api-guidelines/global/json/canonical-data-types/rules/must-use-common-data-formats.md

...delines/global/json/canonical-data-types/rules/should-use-common-format-for-money-amounts.md

dev-context/global/should-use-common-format-for-money-amounts.md

api-guidelines/global/json/canonical-data-types/rules/must-use-common-data-formats.md

...delines/global/json/canonical-data-types/rules/should-use-common-format-for-money-amounts.md

dev-context/global/should-use-common-format-for-money-amounts.md

cgebken

Mostly formatting issues :) I'm focussing on the guideline itself. @kollegolin reviews the decisions from Technical Writing perspective :)

api-guidelines/global/json/canonical-data-types/rules/must-use-common-data-formats.md

changes/changelog.md

api-guidelines/global/json/canonical-data-types/rules/should-use-common-money-object.md

...delines/global/json/canonical-data-types/rules/should-use-common-format-for-money-amounts.md

api-guidelines/global/json/canonical-data-types/rules/should-use-common-money-object.md

api-guidelines/global/json/canonical-data-types/rules/should-use-common-otto-decimal-format.md

decisions/0002-should-use-common-money-object.md

decisions/0001-should-use-common-otto-decimal-format.md

api-guidelines/global/json/canonical-data-types/rules/should-use-common-money-object.md

api-guidelines/global/json/canonical-data-types/rules/should-use-common-otto-decimal-format.md

(cherry picked from commit 1dd2a5f)

Co-authored-by: Max Edenharter <[email protected]>

and also add changelog entries

…se-common-money-object.md Co-authored-by: Christina Framke <[email protected]>

…se-common-otto-decimal-format.md Co-authored-by: Christina Framke <[email protected]>

Co-authored-by: Carolin Wasicki <[email protected]>

Also include negative values in examples for otto:decimal.

cgebken

Thank you for rewriting the sections :) Just some very minor change requests :)

changes/changelog.md

api-guidelines/global/json/canonical-data-types/rules/should-use-common-otto-decimal-format.md

api-guidelines/global/json/canonical-data-types/rules/should-use-common-money-object.md

…se-common-money-object.md Co-authored-by: Christina Framke <[email protected]>

…se-common-otto-decimal-format.md Co-authored-by: Christina Framke <[email protected]>

This reverts commit 57ab324.

changes/changelog.md

cgebken

Guideline files are good to go :)

kollegolin

I found a few minor things. If you'd like to discuss the suggestion regarding two digits after the decimal point and maybe even adding commas, let me know. :)

api-guidelines/global/json/canonical-data-types/rules/should-use-common-otto-decimal-format.md

api-guidelines/global/json/canonical-data-types/rules/should-use-common-otto-money-object.md

decisions/0001-should-use-common-otto-decimal-format.md

api-guidelines/global/json/canonical-data-types/rules/should-use-common-otto-money-object.md

decisions/0002-should-use-common-otto-money-object.md

…se-common-otto-money-object.md Co-authored-by: Carolin Wasicki <[email protected]>

Co-authored-by: Carolin Wasicki <[email protected]>

…se-common-otto-money-object.md Co-authored-by: Carolin Wasicki <[email protected]>

Co-authored-by: Carolin Wasicki <[email protected]>

ccudennec-otto reviewed Apr 30, 2025

View reviewed changes

...delines/global/json/canonical-data-types/rules/should-use-common-format-for-money-amounts.md Outdated Show resolved Hide resolved

maxedenharter0507 requested changes Apr 30, 2025

View reviewed changes

cgebken requested changes May 12, 2025

View reviewed changes

cgebken changed the title ~~Add new guideline for money fields~~ feat(guidelines): add new guideline for money fields May 12, 2025

jensfischer1515 force-pushed the add-money-rule branch from 73fbc6e to 2c5340e Compare June 25, 2025 11:48

cgebken requested changes Jul 1, 2025

View reviewed changes

kollegolin requested changes Jul 1, 2025

View reviewed changes

ErikMartin1740 reviewed Jul 22, 2025

View reviewed changes

api-guidelines/global/json/canonical-data-types/rules/should-use-common-otto-decimal-format.md Outdated Show resolved Hide resolved

JanMeier1337 and others added 20 commits July 30, 2025 16:10

Add new guideline for money amount

232829b

(cherry picked from commit 1dd2a5f)

Update format for money field

2b67596

Incorporated feedback from discussions.

3ad926a

Co-authored-by: Max Edenharter <[email protected]>

more rework

d26b915

moved dev-context into decisions

bc13838

fix some typos, minor wordings and links

378ce93

create ADR for money format rule

f85ead9

and also add changelog entries

Update api-guidelines/global/json/canonical-data-types/rules/should-u…

450f703

…se-common-money-object.md Co-authored-by: Christina Framke <[email protected]>

Update api-guidelines/global/json/canonical-data-types/rules/should-u…

6de7a10

…se-common-money-object.md Co-authored-by: Christina Framke <[email protected]>

Update api-guidelines/global/json/canonical-data-types/rules/should-u…

2643846

…se-common-money-object.md Co-authored-by: Christina Framke <[email protected]>

Update api-guidelines/global/json/canonical-data-types/rules/should-u…

a4225c6

…se-common-money-object.md Co-authored-by: Christina Framke <[email protected]>

Update api-guidelines/global/json/canonical-data-types/rules/should-u…

3713a39

…se-common-otto-decimal-format.md Co-authored-by: Christina Framke <[email protected]>

Update api-guidelines/global/json/canonical-data-types/rules/should-u…

f3dfea2

…se-common-otto-decimal-format.md Co-authored-by: Christina Framke <[email protected]>

Update decisions/0002-should-use-common-money-object.md

83a0243

Co-authored-by: Carolin Wasicki <[email protected]>

Update decisions/0002-should-use-common-money-object.md

f7cab5d

Co-authored-by: Carolin Wasicki <[email protected]>

Update decisions/0002-should-use-common-money-object.md

5bb33e5

Co-authored-by: Carolin Wasicki <[email protected]>

Update decisions/0002-should-use-common-money-object.md

7e67d14

Co-authored-by: Carolin Wasicki <[email protected]>

Update decisions/0002-should-use-common-money-object.md

10936b9

Co-authored-by: Carolin Wasicki <[email protected]>

Update decisions/0001-should-use-common-otto-decimal-format.md

9944247

Co-authored-by: Carolin Wasicki <[email protected]>

Update decisions/0001-should-use-common-otto-decimal-format.md

f034b6b

Co-authored-by: Carolin Wasicki <[email protected]>

jensfischer1515 force-pushed the add-money-rule branch from d1939f2 to 3f733ff Compare July 30, 2025 14:10

jensfischer1515 added 2 commits July 30, 2025 17:09

rewriting of R100080 instead of copy&paste from Zalando.

1ddb94f

Also include negative values in examples for otto:decimal.

Don't list otto:money as it is an object instead of primitive.

35f2b20

maxedenharter0507 approved these changes Jul 31, 2025

View reviewed changes

cgebken requested changes Jul 31, 2025

View reviewed changes

jensfischer1515 and others added 6 commits July 31, 2025 15:54

Update api-guidelines/global/json/canonical-data-types/rules/should-u…

92d98dc

…se-common-money-object.md Co-authored-by: Christina Framke <[email protected]>

Update api-guidelines/global/json/canonical-data-types/rules/should-u…

7fa94a7

…se-common-otto-decimal-format.md Co-authored-by: Christina Framke <[email protected]>

Update api-guidelines/global/json/canonical-data-types/rules/should-u…

109ec57

…se-common-otto-decimal-format.md Co-authored-by: Christina Framke <[email protected]>

Revert "remove changelog.md file as requested"

530fcff

This reverts commit 57ab324.

remove manual changelog entry

62007fe

file renaming

1d2668e

ErikMartin1740 approved these changes Jul 31, 2025

View reviewed changes

cgebken reviewed Aug 1, 2025

View reviewed changes

changes/changelog.md Outdated Show resolved Hide resolved

Remove blank line

0ee8018

cgebken approved these changes Aug 1, 2025

View reviewed changes

kollegolin requested changes Aug 1, 2025

View reviewed changes

jensfischer1515 and others added 9 commits August 1, 2025 11:30

Update api-guidelines/global/json/canonical-data-types/rules/should-u…

904990b

…se-common-otto-money-object.md Co-authored-by: Carolin Wasicki <[email protected]>

Update decisions/0002-should-use-common-otto-money-object.md

d8c47f6

Co-authored-by: Carolin Wasicki <[email protected]>

Update decisions/0002-should-use-common-otto-money-object.md

2a6f349

Co-authored-by: Carolin Wasicki <[email protected]>

Update api-guidelines/global/json/canonical-data-types/rules/should-u…

0cea449

…se-common-otto-money-object.md Co-authored-by: Carolin Wasicki <[email protected]>

Update decisions/0002-should-use-common-otto-money-object.md

4e58d27

Co-authored-by: Carolin Wasicki <[email protected]>

Update decisions/0001-should-use-common-otto-decimal-format.md

170b280

Co-authored-by: Carolin Wasicki <[email protected]>

rework otto:decimal examples

b3d26ac

rework otto:decimal examples

95f61b2

rework otto:decimal examples

6ed8d4f

jensfischer1515 approved these changes Aug 1, 2025

View reviewed changes

Slightly rephrase and reformat example headings

bc5d4b2

kollegolin approved these changes Aug 1, 2025

View reviewed changes

ccudennec-otto approved these changes Aug 4, 2025

View reviewed changes

maxedenharter0507 merged commit b1c82a4 into otto-de:main Aug 4, 2025

feat(guidelines): add new guideline for money fields #89

feat(guidelines): add new guideline for money fields #89

Uh oh!

Conversation

JanMeier1337 commented Apr 30, 2025 • edited by cgebken Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New

Uh oh!

jensfischer1515 commented Apr 30, 2025

Uh oh!

jensfischer1515 commented Apr 30, 2025

Uh oh!

Uh oh!

maxedenharter0507 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cgebken left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cgebken left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cgebken left a comment

Choose a reason for hiding this comment

Uh oh!

kollegolin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

JanMeier1337 commented Apr 30, 2025 •

edited by cgebken

Loading

cgebken left a comment •

edited

Loading