vtep: pg_vtep_add_vni_dst #529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outscale-fne
suggested changes
Mar 30, 2020
There was a problem hiding this comment.
For me it's ok except the blank line :) The make style with cppcheck failed but it seems not important:
.//tests/style/test.sh ./
checkpatch tests OK
lizard is not installed, some tests will be skipped
[/home/outscale/packetgraph/src/brick.c:802]: (error) Uninitialized variable: west_index
[/home/outscale/packetgraph/src/nic.c:58]: (error) Uninitialized variable: portid
[/home/outscale/packetgraph/src/nic.c:58]: (error) Uninitialized variable: it
[/home/outscale/packetgraph/src/vtep-impl.h:830]: (error) Uninitialized variable: port
(information) Cppcheck cannot find all the include files (use --check-config for details)
cppcheck tests failed
Makefile:104: recipe for target 'style' failed
make: *** [style] Error 1
include/packetgraph/vtep.h
Outdated
| @@ -148,6 +158,7 @@ inline int pg_vtep_add_vni(struct pg_brick *brick, | |||
| int pg_vtep_add_mac(struct pg_brick *brick, uint32_t vni, | |||
| struct ether_addr *mac, struct pg_error **errp); | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Il y a une raison pour cette ligne blanche? (le mec relou ;) )
Signed-off-by: Matthias Gatto <[email protected]>
Signed-off-by: Matthias Gatto <[email protected]>
outscale-mgo
force-pushed
the
pg_vtep4_add_vni_dst
branch
from
b3fc8ff
to
e06e338
Compare
Signed-off-by: Matthias Gatto <[email protected]>
outscale-mgo
force-pushed
the
pg_vtep4_add_vni_dst
branch
from
e06e338
to
e647515
Compare
outscale-fne
suggested changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthias Gatto [email protected]