fix: Issue MFE_HOST url redirects to LMS_HOST #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
requested changes
Feb 13, 2024
There was a problem hiding this comment.
Please add a changelog entry: https://docs.tutor.overhang.io/tutor.html#contributing
hinakhadim
force-pushed
the
fix/mfe-url-issue
branch
from
c7aa22a to
a18093a
Compare
hinakhadim
force-pushed
the
fix/mfe-url-issue
branch
from
3ffb179 to
05fb429
Compare
|
@arbrandes what do you think? |
arbrandes
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the #185 . The MFE_HOST url without any MFE name in url redirects to the LMS_HOST url. Before it, the MFE_HOST responds with 204.