node 20 upgrade #226
Merged
node 20 upgrade #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
regisb
approved these changes
Oct 10, 2024
Contributor
regisb
left a comment
regisb
left a comment
There was a problem hiding this comment.
Cool! And this "just works"?
Contributor
Given my past MFE build experience, I find it hard to believe it is that simple. But hey, it is MFE. Anything can happen in this verse. I will test it locally in a while. |
| @@ -0,0 +1,2 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
nit: remove the empty line in the changelog.
DawoudSheraz
approved these changes
Oct 10, 2024
Contributor
DawoudSheraz
left a comment
DawoudSheraz
left a comment
There was a problem hiding this comment.
The mfe image is building with this change, nice one 👍🏽
hinakhadim
approved these changes
Oct 11, 2024
Contributor
hinakhadim
left a comment
hinakhadim
left a comment
There was a problem hiding this comment.
Image is building successfully with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per openedx/public-engineering#267, all Tutor-supported MFEs now work on Node 20, so we're good to switch to the Node 20 image.
Fixes #198