-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add PROFILE_IMAGE_BACKEND settings for k8s #50
fix: add PROFILE_IMAGE_BACKEND settings for k8s #50
Conversation
268de10
to
68b3c12
Compare
13410d8
to
d0bb7c4
Compare
Profile image is now working! This PR is tested with both local and dev environment and with K8s environment as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you just add a comment in the PR to explain how to actually use this private bucket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally using sumac sandbox MINIO host. I uploaded the profile pic, stopped k8s, and then re-launched. The image was there after re-launch and could also be previewed from minio.
- Add PROFILE_IMAGE_BACKEND settings in tutor-minio using patch named `openedx-lms-production-settings` so that profile images persist in k8s deployment of openedx and profile images can work now for both local(will use minio storage if minio plugin is enabled) and dev environment. - In case of dev environment, backend expects the valid S3 `base_url` key in the PROFILE_IMAGE_BACKEND settings. It will be using openedx `DEFAULT_FILE_STORAGE`.
d0bb7c4
to
15efa14
Compare
openedx-lms-production-settings
so that profile images persistin k8s deployment of openedx and profile images can work now for both
local(will use minio storage if minio plugin is enabled) and dev environment.
base_url
key in the PROFILE_IMAGE_BACKEND settings. It will be using openedx
DEFAULT_FILE_STORAGE
.