Use CoreMidi4J devices when available. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard Java MIDI device implementations on Mac OS do not (and never have) supported System Exclusive messages. They also do not properly support MIDI timestamps, even though the underlying CoreMIDI implementation does, even over the network using RTP-MIDI. This change embeds the CoreMidi4J library, which offers fixed versions of the broken MIDI device implementations on Mac OS X, and remains safely idle on other platforms. When CoreMidi4J is active, its versions of MIDI device implementations are used instead of the broken ones.
Now I remember why I originally implemented this using reflection! CoreMidi4J can only load in Java 7 or later, while Clojure still supports Java 6. So we want to let Overtone work the way it used to in Java 6 environments, while using CoreMidi4J in vaguely recent ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard Java MIDI device implementations on Mac OS do not (and
never have) supported System Exclusive messages. They also do not
properly support MIDI timestamps, even though the underlying CoreMIDI
implementation does, even over the network using RTP-MIDI.
This change embeds the CoreMidi4J library, which offers fixed versions
of the broken MIDI device implementations on Mac OS X, and remains
safely idle on other platforms. When CoreMidi4J is active, its versions
of MIDI device implementations are used instead of the broken ones.