fix(pci-kubernetes): add node pool total price, improve node name input #17532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppprevost
force-pushed
the
fix/pci-kubernetes_add-node-price_tapc-3341
branch
3 times, most recently
from
2667696 to
9b06c91
Compare
github-actions
bot
added
has conflicts
ppprevost
force-pushed
the
fix/pci-kubernetes_add-node-price_tapc-3341
branch
from
9b06c91 to
165d7c3
Compare
github-actions
bot
removed
container
has conflicts
ppprevost
force-pushed
the
fix/pci-kubernetes_add-node-price_tapc-3341
branch
3 times, most recently
from
49084d9 to
ca808be
Compare
ppprevost
requested review from
SimonChaumet,
lionel95200x,
Tsiorifamonjena,
selm3n,
lolottetheclash,
Eric-ciccotti and
fredericvilcot
packages/manager/apps/pci-kubernetes/src/pages/detail/nodepools/new/New.page.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-kubernetes/src/pages/detail/nodepools/new/store.ts
Show resolved
Hide resolved
ppprevost
force-pushed
the
fix/pci-kubernetes_add-node-price_tapc-3341
branch
2 times, most recently
from
5761e58 to
7489ee3
Compare
SimonChaumet
previously approved these changes
Jun 11, 2025
ppprevost
force-pushed
the
fix/pci-kubernetes_add-node-price_tapc-3341
branch
from
7489ee3 to
314a062
Compare
ppprevost
force-pushed
the
fix/pci-kubernetes_add-node-price_tapc-3341
branch
from
314a062 to
b29f186
Compare
SimonChaumet
previously approved these changes
Jun 12, 2025
ppprevost
force-pushed
the
fix/pci-kubernetes_add-node-price_tapc-3341
branch
from
b29f186 to
20adfc6
Compare
ref: #TAPC-3341 Signed-off-by: Pierre-Philippe <[email protected]>
ppprevost
force-pushed
the
fix/pci-kubernetes_add-node-price_tapc-3341
branch
from
20adfc6 to
b2f1caf
Compare
fredericvilcot
approved these changes
Jun 12, 2025
Tsiorifamonjena
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #TAPC-3341
Description
The goal of this pull request is to correctly display the price of nodes based on the number of machines. It includes the following changes:
Correction of the size of the input fields for name cluster and name node.
Fixes for TypeScript types.
Ticket Reference: #...
Additional Information