Skip to content

feat(vcd): add searchbar and filter on vdc datagrid #17915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

tibs245
Copy link
Contributor

@tibs245 tibs245 commented Jul 1, 2025

Description

Ticket Reference: #MANAGER-18723

Additional Information

@tibs245 tibs245 marked this pull request as ready for review July 1, 2025 17:11
@tibs245 tibs245 requested a review from a team as a code owner July 1, 2025 17:11
@github-actions github-actions bot added the feature New feature label Jul 1, 2025
darsene
darsene previously approved these changes Jul 2, 2025
sefiani-ovh
sefiani-ovh previously approved these changes Jul 2, 2025
@tibs245 tibs245 dismissed stale reviews from sefiani-ovh and darsene via faac9e4 July 2, 2025 12:51
darsene
darsene previously approved these changes Jul 2, 2025
Copy link
Contributor

@pauldkn pauldkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a branchName as reference on one of your commit, maybe you should change this

PS: don't hesitate to use the yarn-commit script to prevent this

@tibs245 tibs245 force-pushed the feat/MANAGER-18723-add-vdc-search-and-filters branch from faac9e4 to 27af2a5 Compare July 2, 2025 13:07
pauldkn
pauldkn previously approved these changes Jul 2, 2025
tibs245 added 2 commits July 7, 2025 17:40
ref: #MANAGER-18723

Signed-off-by: Thibault Barske <[email protected]>
ref: #MANAGER-18723

Signed-off-by: Thibault Barske <[email protected]>
@tibs245 tibs245 dismissed stale reviews from pauldkn and darsene via 13e7e26 July 7, 2025 15:59
@tibs245 tibs245 force-pushed the feat/MANAGER-18723-add-vdc-search-and-filters branch from 27af2a5 to 13e7e26 Compare July 7, 2025 15:59
ref: #MANAGER-18723

Signed-off-by: Thibault Barske <[email protected]>
@tibs245 tibs245 force-pushed the feat/MANAGER-18723-add-vdc-search-and-filters branch from 13e7e26 to 01c405c Compare July 7, 2025 16:16
Comment on lines +26 to +34
vi.mock('@ovhcloud/ods-components/react', async (importOriginal) => {
const actual: any = await importOriginal();
return {
...actual,
OdsLink: vi
.fn()
.mockImplementation(({ label, ...rest }) => <a {...rest}>{label}</a>),
};
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted: I can delete it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants