Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNC-2769] Add optional prod approval step to release #478

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jensraaby
Copy link
Contributor

@jensraaby jensraaby commented Aug 3, 2022

This needs testing (assuming I can remember how to reference the orb by git branch)

@jensraaby jensraaby requested a review from a team as a code owner August 3, 2022 15:57
Copy link

@tomp4l tomp4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, what's this orb used for though?

@tomp4l
Copy link

tomp4l commented Aug 3, 2022

Spoke to soon, it's not valid schema 😢

@jensraaby
Copy link
Contributor Author

Spoke to soon, it's not valid schema 😢

You're too quick! I didn't realise it would add reviewers to the PR straight away.

It looks like I can't add a conditional "job" to another job, so I'm back to square one.
The "release" job was the original deploy workflow for everything until incident-gate. I noticed with the neo facade that the template was using it, so I was hoping rather than wiring together a whole new job I'd be able to just add in the approval bit as optional (in case something else is using it and we don't want to add manual approval).

@jensraaby jensraaby marked this pull request as draft August 3, 2022 16:24
@tomp4l
Copy link

tomp4l commented Aug 3, 2022

Makes sense, shame we can't do it like this, it looked sensible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants