-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added Github CI workflow #317
Conversation
@theseion many thanks for your suggestion. Please take a review again, if everything is fine I'm going to merge it. |
Looks to me like you were trying to set environment variables from scripts, but scripts are isolated, so - name: Build nginx with ModSecurity-nginx module
working-directory: nginx
env:
CC: "${{ matrix.compiler }}"
run: |
echo "Compiler: ${CC}"
./auto/configure --with-ld-opt="-Wl,-rpath,/usr/local/lib" --without-pcre2 --add-module=/home/runner/work/ModSecurity-nginx/ModSecurity-nginx/ModSecurity-nginx
make
make modules
sudo make install |
Thanks! How can I use environment variables in evaluation, eg. in an if [ matrix.compiler == "gcc" ]; then
...
|
By passing it through an environment variable like so: - name: a script
env:
COMPILER: "${{ matrix.compiler }}"
run: |
if [ "${COMPILER}" == "gcc" ]; then
... |
I'm afraid in this case the evaluated code will be something similar: if [ "gcc" == "gcc" ]; then which is always true. |
Quality Gate passedIssues Measures |
See the newest clear version: #318. |
Added
.github/workflow/ci.yml
and necessary files with a complex test workflow for each PR.A brief summary about how does it work: