Skip to content

📊 Korevaar Housing Data #4708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

📊 Korevaar Housing Data #4708

wants to merge 9 commits into from

Conversation

antea04
Copy link
Contributor

@antea04 antea04 commented Jul 11, 2025

Import long run data from "The housing affordability revolution" for the housing data page. Data was shared with us via email.

@owidbot
Copy link
Contributor

owidbot commented Jul 11, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-data-korevaar-housing

chart-diff: ✅
  • 3/3 reviewed charts
  • Modified: 0/0
  • New: 3/3
  • Rejected: 0
  • Data changes: 0
  • Metadata changes: 0
data-diff: ❓ No datasets found in REMOTE

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2025-07-14 15:07:52 UTC
Execution time: 4.84 seconds

@antea04 antea04 marked this pull request as ready for review July 14, 2025 15:29
Copy link
Contributor

@veronikasamborska1994 veronikasamborska1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a very interesting dataset! I’ve left a couple of comments. Beyond the issue I already flagged on Slack, I think the metadata could really be improved — especially considering this is such a long-run dataset.

p.s. once you fix these issues I can take another look at the charts as for now there seems to be a couple of bigger issues going on.

@@ -0,0 +1,108 @@
# NOTE: To learn more about the fields, hover over their names.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a very broad overall comment is that a lot of key information seems to be missing here - e.g. how do the authors estimate these long term trends; what kind of inflation adjustment is done etc. I'll add a couple more below but overall I'd say the metadata probably needs a bit of work given that you have historical data and people might wonder where these estimates come from

unit: Index
short_unit: ""
real_wage:
title: Real wages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super unclear what adjusted for inflation here means? Is the other data not adjusted then?

short_unit: ""
real_rent:
title: Real rents
description_short: Real rents, normalized to 1900=100. These values are adjusted for inflation and improvements in quality of the housing stock.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is the quality of housing stock being adjusted for?

"Belgian cities": "Belgium",
"Bruges": "Bruges",
"Brussels": "Brussels",
"Gent": "Gent",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an inconsistency in the city naming between files. In korevaar_quality.py (line 73), "Gent" is being replaced with "Ghent":

tb_bel = tb_bel.replace({"city": {"Gent": "Ghent"}})

However, in the country mapping file, "Gent" is listed as its own entity. The naming should be consistent across all files to avoid data mismatches. Either standardize on "Ghent" everywhere or keep "Gent" consistently.

Suggested change
"Gent": "Gent",
"Gent": "Ghent",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Comment on lines +98 to +99
title: Percentage of households with isolation
description_short: Percentage of households that have heat isolation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term "heat isolation" in the description is potentially confusing. Consider replacing with "thermal insulation" or "heat insulation" which are more standard terms in English for describing this housing feature.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants