-
-
Notifications
You must be signed in to change notification settings - Fork 22
📊 Korevaar Housing Data #4708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
📊 Korevaar Housing Data #4708
Conversation
Quick links (staging server):
Login: chart-diff: ✅
data-diff: ❓ No datasets found in REMOTEAutomatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included Edited: 2025-07-14 15:07:52 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a very interesting dataset! I’ve left a couple of comments. Beyond the issue I already flagged on Slack, I think the metadata could really be improved — especially considering this is such a long-run dataset.
p.s. once you fix these issues I can take another look at the charts as for now there seems to be a couple of bigger issues going on.
@@ -0,0 +1,108 @@ | |||
# NOTE: To learn more about the fields, hover over their names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a very broad overall comment is that a lot of key information seems to be missing here - e.g. how do the authors estimate these long term trends; what kind of inflation adjustment is done etc. I'll add a couple more below but overall I'd say the metadata probably needs a bit of work given that you have historical data and people might wonder where these estimates come from
unit: Index | ||
short_unit: "" | ||
real_wage: | ||
title: Real wages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super unclear what adjusted for inflation here means? Is the other data not adjusted then?
short_unit: "" | ||
real_rent: | ||
title: Real rents | ||
description_short: Real rents, normalized to 1900=100. These values are adjusted for inflation and improvements in quality of the housing stock. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is the quality of housing stock being adjusted for?
"Belgian cities": "Belgium", | ||
"Bruges": "Bruges", | ||
"Brussels": "Brussels", | ||
"Gent": "Gent", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an inconsistency in the city naming between files. In korevaar_quality.py
(line 73), "Gent" is being replaced with "Ghent":
tb_bel = tb_bel.replace({"city": {"Gent": "Ghent"}})
However, in the country mapping file, "Gent" is listed as its own entity. The naming should be consistent across all files to avoid data mismatches. Either standardize on "Ghent" everywhere or keep "Gent" consistently.
"Gent": "Gent", | |
"Gent": "Ghent", |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
title: Percentage of households with isolation | ||
description_short: Percentage of households that have heat isolation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term "heat isolation" in the description is potentially confusing. Consider replacing with "thermal insulation" or "heat insulation" which are more standard terms in English for describing this housing feature.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Import long run data from "The housing affordability revolution" for the housing data page. Data was shared with us via email.