Skip to content

[FIX] Change spaces icon for folder in details view for the personal space #4640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2025
Merged

[FIX] Change spaces icon for folder in details view for the personal space #4640

merged 3 commits into from
Jul 15, 2025

Conversation

joragua
Copy link
Collaborator

@joragua joragua commented Jul 15, 2025 •
edited
Loading

Related Issues

App: #4624

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this Jul 15, 2025
@joragua joragua linked an issue Jul 15, 2025 that may be closed by this pull request
[BUG] Change spaces icon for folder in details view for the personal space #4624
Closed
@joragua joragua marked this pull request as ready for review July 15, 2025 11:55
@joragua joragua requested a review from jesmrec July 15, 2025 11:55
@jesmrec
Copy link
Collaborator

jesmrec commented Jul 15, 2025

LGTM 👍

@joragua joragua force-pushed the fix/personal_icon_in_file_details_view branch from 7925572 to 262b276 Compare July 15, 2025 14:51
@jesmrec jesmrec force-pushed the fix/personal_icon_in_file_details_view branch from 7bac495 to bfcea70 Compare July 15, 2025 14:59
@jesmrec
Copy link
Collaborator

jesmrec commented Jul 15, 2025 •
edited
Loading

QA checks:

  • oC10: no spaces
  • oCIS personal space -> folder icon
  • oCIS custom space -> space icon
  • Kiteworks: no personal -> space icon

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 15, 2025

Approved

@jesmrec jesmrec merged commit 8b1bcaa into master Jul 15, 2025
9 checks passed
@jesmrec jesmrec deleted the fix/personal_icon_in_file_details_view branch July 15, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesmrec jesmrec jesmrec approved these changes

Assignees

@joragua joragua

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Change spaces icon for folder in details view for the personal space
3 participants
@joragua @jesmrec @ownclouders