Skip to content

[FIX] Mini-fab for creating a new document not always available #4649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2025
Merged

[FIX] Mini-fab for creating a new document not always available #4649

merged 3 commits into from
Jul 25, 2025

Conversation

joragua
Copy link
Collaborator

@joragua joragua commented Jul 25, 2025 •
edited
Loading

Related Issues

App: https://github.com/owncloud/enterprise/issues/7277

The new productName property introduced in this PR (#4562) is missing in the JSON response from ByCS (and other customers might face the same issue). The solution is to make the property nullable to prevent crashes and allow the mini-FAB to appear, using the defaultApplication value as a fallback.

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this Jul 25, 2025
@joragua joragua marked this pull request as ready for review July 25, 2025 09:23
@joragua joragua requested a review from jesmrec July 25, 2025 09:23
@jesmrec jesmrec added this to the 4.6 - Current milestone Jul 25, 2025
jesmrec
jesmrec approved these changes Jul 25, 2025
View reviewed changes
@joragua joragua changed the title [FIX] Document editing not available on ByCS [FIX] Mini-fab for creating a new document not always available Jul 25, 2025
@joragua joragua force-pushed the fix/bycs_without_document_editing branch from 77c6f74 to 67a271b Compare July 25, 2025 10:42
@joragua joragua force-pushed the fix/bycs_without_document_editing branch from e46eaa3 to 5537229 Compare July 25, 2025 10:52
@jesmrec
Copy link
Collaborator

jesmrec commented Jul 25, 2025 •
edited
Loading

QA checks

  • Mini fab present in instances 1, 2 and 3
  • Create document in instance 1
  • Create document in instance 2
  • Create document in instance 3
  • Open and edit file in instance 1
  • Open and edit file in instance 2
  • Open and edit file in instance 3

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 25, 2025

Approved from my side

@joragua joragua merged commit faeb671 into master Jul 25, 2025
10 checks passed
@joragua joragua deleted the fix/bycs_without_document_editing branch July 25, 2025 11:53
@jesmrec jesmrec mentioned this pull request Jul 31, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesmrec jesmrec jesmrec approved these changes

Assignees

@joragua joragua

Labels
Approved by qa Estimation - 2 (S) File list
Projects
None yet
Milestone
4.6 - Current
Development

Successfully merging this pull request may close these issues.
3 participants
@joragua @jesmrec @ownclouders