[TECHNICAL] Resource leak in CopyAndUploadContentUrisTask

[dataCenter430]

…UrisTask

Related Issues

Fixes #4797

Summary

Fixes a resource leak in CopyAndUploadContentUrisTask reported in #4797.

Problem

In the loop over URIs (lines 147–182), inputStream and outputStream were reassigned every iteration but never closed inside the loop. Only the last iteration’s streams were closed in the outer finally block, so all previous streams were leaked (file descriptors and memory).

Solution

• Use try-with-resources inside the loop so each iteration opens and closes its own InputStream and FileOutputStream.
• Remove the outer inputStream/outputStream variables and the stream-closing logic from the outer finally block.

Each URI’s streams are now closed at the end of that iteration (normal or exceptional), so no streams are leaked.

• Add changelog files for the fixed issues in folder changelog/unreleased. More info here

[dataCenter430]

Hi, @joragua
Sorry for the late PR.
I really appreciate your review with this.
Thank you

[joragua]

Thanks for your contribution @dataCenter430! 💯 I'll check this PR as soon as possible

[dataCenter430]

Hi, @joragua
Sorry to ping you, are there any updates yet?
Thank you.

[joragua]

Just two comments and it's ready @dataCenter430! 👍🏻

[dataCenter430]

Thanks for your review, 👍 @joragua
Could you please review it and let me know any feedback?

[joragua]

LGTM! Let's check that nothing is broken with the changes 🚀

[jesmrec]

Just realised one tiny detail: in the changelog file, you defined it as a Bugfix . It's not really a bugfix because the previous behaviour was correct (even when the new one is better 😄 ). Would you mind to set it as Change ? we think, Change matches better.

After re-checking every kind of involved upload (manual, from camera, external, doc provider, external doc), no problem was found. So, it is approved on my side 💯

@dataCenter430 could you perform the change in the calens file and rebase the branch, to be merged? Thanks for your patience!!

[dataCenter430]

Hi, @jesmrec thanks for your review.
I've rebased the branch, are you able to check it?
Thank you

[jesmrec]

I've rebased the branch, are you able to check it?

i checked it, but i realised you merged master into this branch (not the same as rebase). We try to avoid merge commits to keep the history clean and clear. Could you remove the merge commit and rebase the branch? let us know if you need any help.

[dataCenter430]

It looks like to be done, no conflict, no error
Thank you again, @jesmrec 👍

[jesmrec]

Thanks to you for your engagement @dataCenter430. Merging... it will be included in 4.8.0