[DC-49] feature: start removing support for OC10#12167
Merged
Conversation
…DetermineAuthTypeAdapter the AuthenticationType enum lives in the adapter for now, but this is temporary. also added a few todo's from the refactoring todo list
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
there are a few traces left in the basic http/credentials code but that is going away in the next commit
…f legacy webfinger support) also improved the docs for the new adapters
… obvious guis also did some various cleanup, renaming, and streamlining still need to tighten up the handling of the authentication type in HttpCredentials as this is the most logical "owner" of that value.
… to credentialssupport.h removed the DetermineAuthTypeJob class fixed various includes while removing overuse of #include httpcredentials.h
use it to check whether the server supports spaces in the final auth checks. If not, the server is rejected and no account is created. added a few todo's cleaned up dead comments. still need to test this on kw (I don't anticipate any issues there) and also with webfinger
erikjv
requested changes
Jun 6, 2025
Contributor
Author
|
we can't merge this yet - pending outside decisions |
erikjv
approved these changes
Jun 6, 2025
DeepDiver1975
approved these changes
Jun 6, 2025
This was referenced Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://kiteworks.atlassian.net/browse/DC-49