Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/storage based encryption key location 2 10.9 #40893

Draft
wants to merge 34 commits into
base: master
Choose a base branch
from
Draft

Feat/storage based encryption key location 2 10.9 #40893

wants to merge 34 commits into from

Conversation

DeepDiver1975
Copy link
Member

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

JammingBen and others added 30 commits December 28, 2021 13:43
@JammingBen
Prevent encrypted files from being corrupted when overwriting them
4e94ef8
@JammingBen
Add changelog item for #39623
f65e6f0
@JammingBen
Fix getHeader unit tests
b30ff05
@JammingBen
Move changelog item #39623 to the released folder
636258d
@micbar
Bump version in version.php
92f779c
@micbar
Update CHANGELOG
5627304
@JammingBen
Fix getting the file owner for share recipients
35d97bf
@JammingBen
Fix issue with wrong version authors being saved
6f651a0
@JammingBen
Merge pull request #39670 from /issues/39662
35261dd 
Fix getting the file owner for share recipients
@JammingBen
Merge pull request #39673 from /issues/39672
c1a7b23 
Fix issue with wrong version authors being saved
@jnweiger
bump version to 10.9.1 RC2
b1e97b8
@jnweiger
Rename the last changelog folder, so that calens gets the date right,…
99f5cb9 
… if running.
@jnweiger
bump version for final, update changelog via calens
9ba23c2
@jnweiger
updated CHANGELOG via calens
515d81b
@DeepDiver1975
feat: encryption keys location can be specified by the storage implem…
faae8d8 
…entation
@DeepDiver1975
feat: decrypt the stream of a file version as returned by IVersionedS…
9d0ea82 
…torage
@DeepDiver1975
fix: encryption storage wrapper will only delete keys if the storage …
254e793 
…has no own key handling
@JammingBen @DeepDiver1975
Add unit tests for versioned storage methods
ff070d0
@DeepDiver1975
fix: handle encryption keys with trashbin
e9106fe
@DeepDiver1975
feat: add before_moveToTrash hook + add fileId to delete hook
b67b159
@DeepDiver1975
feat: adding new storage method getFileKey
bad33e0
@DeepDiver1975
feat: adding new storage method setFileKey
db2e52c
@DeepDiver1975
fix: trashbin pre_restore hook and encryption version on move
4da52be
@DeepDiver1975
feat: versioned storages are expected to handle retainVersions themse…
746b8e8 
…lves
@DeepDiver1975
fix: handle file rename properly
c8bf2da
@DeepDiver1975
feat: copy trashed items to all owner trash bins
4c17c69
@DeepDiver1975
feat: detect collisions of mounts wit local files
3bc27db
@DeepDiver1975
feat: add absolute paths to rename hook
36d31a9
@DeepDiver1975
fix: remove just uploaded files in case of error - also for storages …
53543f1 
…which do not support part files
@DeepDiver1975
fix: better error handling on file upload
6ebf40b
@DeepDiver1975
Copy link
Member Author

it is honestly 💩 that it is impossible to run ci on pr targeting older versions .... that's beyond the purpose of a ci system .... 😠

@phil-davis
Copy link
Contributor

The CI "system" that existed for 10.9 no longer "exists". The drone secrets that were used then have been removed from the drone server and agents.
A similar thing happens if you try to run CI for an old oC10 from when we used Jenkins, or Travis, or... - in that case there is no Jenkins, Travis... server even online at all. So CI will have no chance to start.
The CI "scripts" that go with an old branch always depend on having a similar execution environment available for those "scripts".
If it is needed, then we can apply updated CI scripts and tools to an older branch and get it going.

@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2-10.9 branch from 765e49e to c2e062f Compare August 2, 2023 08:06
@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2-10.9 branch 2 times, most recently from ed3b757 to 3398ae0 Compare August 4, 2023 08:17
@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2-10.9 branch from 0e58c58 to f9b76f6 Compare August 4, 2023 08:24
@IljaN IljaN changed the base branch from 10.9.x to master November 15, 2023 14:42
@IljaN
feat: make restore abortable from within pre_restore (#41316)
23ae2da 
Additionally this also passes the original restore location
of the inaccessible path before it is rewritten to the path
in home.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DeepDiver1975 @phil-davis @JammingBen @micbar @jnweiger @IljaN