Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove PHPdoc of non-existent parameter #41256

Closed
wants to merge 3 commits into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented May 28, 2024

Description

Actually I just want to change some irrelevant thing to check if drone CI is OK.

Related Issue

This is to investigate issue #41257

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis
Copy link
Contributor Author

Because of sonar-analysis failing in #41255 (comment)

Maybe there is a general problem with sonar-analysis?

@phil-davis
Copy link
Contributor Author

sonar-analysis is failing:

https://drone.owncloud.com/owncloud/core/39945/29/9

"something happened" (tm) in the last day to sonar-analysis.

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/core/39946/29/9
got the same fail:

Caused by: java.nio.file.AccessDeniedException: /drone/src/data

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@phil-davis
Copy link
Contributor Author

SonarCloud support suggested trying pinning to sonarsource/sonar-scanner-cli:5

That works. I have cherry-picked the change into PR #41255 to get CI passing there, and I will merge it. We can follow-up later with sorting out how to use the latest SonarCloud docker image.

@phil-davis phil-davis closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant