[full-ci] add docs for generating the coverage report and setting report coverage on sonarcloud #11081
+228
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
nirajacharya2
force-pushed
the
code-coverage-from-acceptance-test
branch
27 times, most recently
from
a90fdfc to
c29e0ca
Compare
nirajacharya2
force-pushed
the
code-coverage-from-acceptance-test
branch
2 times, most recently
from
fd9023e to
670083f
Compare
nirajacharya2
force-pushed
the
code-coverage-from-acceptance-test
branch
from
670083f to
9867d6c
Compare
individual-it
requested changes
Apr 2, 2025
nirajacharya2
force-pushed
the
code-coverage-from-acceptance-test
branch
from
9867d6c to
0251257
Compare
|
|
Add information about how to generate, where the coverage will be, and how to access it if someone is interested.
|
nirajacharya2
force-pushed
the
code-coverage-from-acceptance-test
branch
from
0251257 to
499672a
Compare
nirajacharya2
changed the title
nirajacharya2
force-pushed
the
code-coverage-from-acceptance-test
branch
2 times, most recently
from
7146acc to
c846209
Compare
nirajacharya2
force-pushed
the
code-coverage-from-acceptance-test
branch
from
c846209 to
d5f2d4a
Compare
phil-davis
reviewed
Apr 8, 2025
Comment on lines
+40
to
+46
| # Ignore "Define a constant instead of duplicating this literal" rule for tests | ||
| sonar.issue.ignore.multicriteria.g1.ruleKey=go:S1192 | ||
| sonar.issue.ignore.multicriteria.g1.resourceKey=**/*_test.go | ||
|
|
||
| # Ignore "Rename function XXX to match the regular expression ^(_|[a-zA-Z0-9]+)$" rule for tests | ||
| sonar.issue.ignore.multicriteria.g2.ruleKey=go:S100 | ||
| sonar.issue.ignore.multicriteria.g2.resourceKey=**/*_test.go |
There was a problem hiding this comment.
I suppose that we need to ignore "code quality" errors because this Sonar run is only for gathering code coverage.
The "regular" Sonar run that goes with unit tests be the one that we care about for "code quality" feedback.
… the coverage report
nirajacharya2
force-pushed
the
code-coverage-from-acceptance-test
branch
from
d5f2d4a to
732dd01
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds docs for getting the coverage report form acceptance test and pushes the report to sonarcloud.
the coverage report will be viewable at https://sonarcloud.io/summary/new_code?id=owncloud-1_ocis_acceptance-tests after this pr is merged
output:
~/ocis$ go tool covdata percent -i=somedata github.com/owncloud/ocis/v2/ocis-pkg/account coverage: 100.0% of statements github.com/owncloud/ocis/v2/ocis-pkg/ast coverage: 23.1% of statements github.com/owncloud/ocis/v2/ocis-pkg/broker coverage: 33.3% of statements github.com/owncloud/ocis/v2/ocis-pkg/capabilities coverage: 100.0% of statements github.com/owncloud/ocis/v2/ocis-pkg/checks coverage: 60.0% of statements github.com/owncloud/ocis/v2/ocis-pkg/clihelper coverage: 100.0% of statements github.com/owncloud/ocis/v2/ocis-pkg/config coverage: 88.5% of statements github.com/owncloud/ocis/v2/ocis-pkg/config/configlog coverage: 55.6% of statements github.com/owncloud/ocis/v2/ocis-pkg/config/defaults coverage: 54.5% of statements github.com/owncloud/ocis/v2/ocis-pkg/config/envdecode coverage: 42.4% of statements github.com/owncloud/ocis/v2/ocis-pkg/config/parser coverage: 86.2% of statements github.com/owncloud/ocis/v2/ocis-pkg/conversions coverage: 44.4% of statements github.com/owncloud/ocis/v2/ocis-pkg/cors coverage: 100.0% of statements github.com/owncloud/ocis/v2/ocis-pkg/crypto coverage: 58.2% of statements github.com/owncloud/ocis/v2/ocis-pkg/generators coverage: 77.8% of statements github.com/owncloud/ocis/v2/ocis-pkg/handlers coverage: 49.0% of statements github.com/owncloud/ocis/v2/ocis-pkg/keycloak coverage: 0.0% of statements github.com/owncloud/ocis/v2/ocis-pkg/kql coverage: 49.5% of statements github.com/owncloud/ocis/v2/ocis-pkg/l10n coverage: 17.0% of statements github.com/owncloud/ocis/v2/ocis-pkg/ldap coverage: 78.6% of statements github.com/owncloud/ocis/v2/ocis-pkg/log coverage: 65.8% of statements github.com/owncloud/ocis/v2/ocis-pkg/middleware coverage: 50.0% of statements github.com/owncloud/ocis/v2/ocis-pkg/natsjsregistry coverage: 65.2% of statements github.com/owncloud/ocis/v2/ocis-pkg/oidc coverage: 46.7% of statements github.com/owncloud/ocis/v2/ocis-pkg/registry coverage: 80.2% of statements github.com/owncloud/ocis/v2/ocis-pkg/roles coverage: 83.9% of statements github.com/owncloud/ocis/v2/ocis-pkg/service/debug coverage: 88.1% of statements github.com/owncloud/ocis/v2/ocis-pkg/service/grpc coverage: 62.2% of statements github.com/owncloud/ocis/v2/ocis-pkg/service/grpc/handler/ratelimiter coverage: 21.4% of statements github.com/owncloud/ocis/v2/ocis-pkg/service/http coverage: 86.4% of statements github.com/owncloud/ocis/v2/ocis-pkg/shared coverage: 47.4% of statements github.com/owncloud/ocis/v2/ocis-pkg/structs coverage: 100.0% of statements github.com/owncloud/ocis/v2/ocis-pkg/sync coverage: 35.7% of statements github.com/owncloud/ocis/v2/ocis-pkg/tracing coverage: 14.8% of statements github.com/owncloud/ocis/v2/ocis-pkg/version coverage: 72.7% of statements github.com/owncloud/ocis/v2/ocis-pkg/x/io/fsx coverage: 90.0% of statements github.com/owncloud/ocis/v2/ocis-pkg/x/path/filepathx coverage: 100.0% of statementsor the webui view
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: