Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] refactor: define either handler or route in editor actions, not both #11857

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Nov 6, 2024

Description

Seems weird that we define both a handler for a button and a route for a router-link in editor actions. Let's see what CI says if we only define the one that's needed (route, with fallback to a handler when no route is available).

Related Issue

Motivation and Context

hardening

How Has This Been Tested?

Perfect CI test coverage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Copy link

update-docs bot commented Nov 6, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

sonarcloud bot commented Nov 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant