[tests-only][full-ci]Setup keycloak group e2e tests #11887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrita-shrestha
force-pushed
the
e2e-keycloack-test
branch
from
bf2374c
to
df439d0
Compare
amrita-shrestha
changed the title
amrita-shrestha
requested review from
S-Panta,
saw-jan,
nabim777,
anon-pradip,
SagarGi,
prashant-gurung899,
Salipa-Gurung,
PrajwolAmatya and
ishabaral
and removed request for
S-Panta and
saw-jan
amrita-shrestha
force-pushed
the
e2e-keycloack-test
branch
from
6b00a5d
to
5cdf814
Compare
|
saw-jan
reviewed
Nov 15, 2024
| @@ -160,3 +160,13 @@ export const assignRole = async (admin: User, id: string, role: string): Promise | |||
| }) | |||
| checkResponseStatus(response, 'Failed while assigning role to the user') | |||
| } | |||
|
|
|||
| export const getGroup = async ({ admin }: { admin: User }) => { | |||
There was a problem hiding this comment.
Suggested change
| export const getGroup = async ({ admin }: { admin: User }) => { | |
| export const getGroups = async (admin: User) => { |
Comment on lines
+165
to
+171
| return ( | ||
| await request({ | ||
| method: 'GET', | ||
| path: join('graph', 'v1.0', 'groups'), | ||
| user: admin | ||
| }) | ||
| ).json() |
There was a problem hiding this comment.
return array of groups. not a full response
| /* | ||
| store group created from keycloak on store | ||
| */ | ||
| const storeGroup = async (user: User, usersEnvironment) => { |
There was a problem hiding this comment.
Suggested change
| const storeGroup = async (user: User, usersEnvironment) => { | |
| const storeKeycloakGroups = async (user: User, usersEnvironment) => { |
Comment on lines
8
to
+11
| federatedUserStore | ||
| } from '../store' | ||
| import { config } from '../../config' | ||
| import { dummyKeycloakGroupStore } from '../store/keycloak' |
There was a problem hiding this comment.
why not?
Suggested change
| federatedUserStore | |
| } from '../store' | |
| import { config } from '../../config' | |
| import { dummyKeycloakGroupStore } from '../store/keycloak' | |
| federatedUserStore, | |
| dummyKeycloakGroupStore | |
| } from '../store' | |
| import { config } from '../../config' |
| @@ -41,6 +41,8 @@ import { | |||
| } from '../../support/api/keycloak' | |||
| import { closeSSEConnections } from '../../support/environment/sse' | |||
| import { setAccessAndRefreshToken } from '../../support/api/token' | |||
| import { dummyKeycloakGroupStore } from '../../support/store/keycloak' | |||
There was a problem hiding this comment.
it can be imported in the above import statement
Suggested change
| import { dummyKeycloakGroupStore } from '../../support/store/keycloak' |
saw-jan
reviewed
Nov 15, 2024
Comment on lines
+71
to
+78
| When "Admin" deletes the following groups using the batch actions | ||
| | group | | ||
| | security | | ||
| | finance | | ||
| Then "Admin" should not see the following groups | ||
| | group | | ||
| | security | | ||
| | finance | |
There was a problem hiding this comment.
why do we need these ocis group steps? one should be enough if you insist
There was a problem hiding this comment.
to test keycloak integration doesn't affect oCIS side group
saw-jan
reviewed
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR covers :
Note
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: