Fix progress bar display when terminal width is too small #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vawale
force-pushed
the
fix-repeated-lines-for-small-terminal-width
branch
from
925a5bd
to
d248ab4
Compare
When the terminal width is too small, we run into problems as mentioned in p-ranav#132. This PR fixes the problem by keeping track of number of wrapped lines printed by progress bar and erasing those extra wrapped lines before printing progress for next iteration. For multi_progress bar and dynamic_progress bar, we need to move cursor to start before each iteration by summing up number of wrapped lines for each bar. Since each bar's `print_progress` expects cursor to be on last printed line, we move cursor down by number of wrapped lines before printing progress for each bar. I have not yet handled case when `dynamic_progress` option `hide_bar_when_complete` is set. Fixes Issue p-ranav#132
vawale
force-pushed
the
fix-repeated-lines-for-small-terminal-width
branch
from
d248ab4
to
b06a9c1
Compare
`move_down` function on windows actually ended up moving the cursor up. Fix this bug.
|
@p-ranav Can you please take a look at this PR? This solves some of the issues I faced with using indicators. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the terminal width is too small, we run into problems as mentioned in #132. This PR fixes the problem by keeping track of number of wrapped lines printed by progress bar and erasing those extra wrapped lines before printing progress for next iteration.
For multi_progress bar and dynamic_progress bar, we need to move cursor to start before each iteration by summing up number of wrapped lines for each bar. Since each bar's
print_progressexpects cursor to be on last printed line, we move cursor down by number of wrapped lines before printing progress for each bar.I have not yet handled case when
dynamic_progressoptionhide_bar_when_completeis set.Fixes Issue #132