Merge fork upstream with dependency and other misc updates #256
+1,553
−4,834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to pa11y v8 and other dependency updates
Configure Renovate
…de-4.x Update actions/setup-node action to v4
Update dependency cheerio to ^1.0.0
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
aarongoldenthal
added
type: bug
type: maintenance
dependencies
jpw
approved these changes
Jul 16, 2025
Contributor
jpw
left a comment
jpw
left a comment
There was a problem hiding this comment.
This is a great PR, and no small amount of work!
Thanks very much @aarongoldenthal ❤️
This was referenced Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges dependency updates, associated refactored code/tests, and several miscellaneous updates to incorporate all relevant updates from fork
@aarongoldenthal/pa11y-ciinto pa11y-ci.Dependencies updates with impacts to pa11y-ci
puppeteerfrom 20.9.0 to 24.7.2, which updated from Chrome 115 to Chrome 135.puppeteer@24removed deprecated launch option interface, which should not be breaking as the new interface only adds capabilities. See thepuppeteerdocumentation for complete details.puppeteer@22renamedcreateIncognitoBrowserContexttocreateBrowserContextper refactor!: rename createIncognitoBrowserContext to createBrowserContext puppeteer/puppeteer#11834, which required refactoringlib/pa11y-ci.js, some unit tests, andpuppeteer.mock.js.puppeteer@22changed the timeout error message text from "timed out" to "timeout", which required refactoring several integration tests.puppeteerrelease (24.8.2), but matches[email protected].pa11yfrom v7.0.0 to v9.0.0.puppeteer@24and requires Node 20+. Updatedpa11y-cito match required Node version.puppeteer@22, which defaults to Chrome's new headless mode. Thepa11ymigration guide has more details on the impacts.commanderfrom 11.1.0 to 13.1.0.bin/pa11y-ci.jsto replace the default export (which was removed) with the classCommand, and to allow an arbitrary number of arguments (theallowExcessArguments()call). See the v12 and v13 migration tips.Security updates
asyncfrom 3.2.5 to 3.2.6, resolving CVE-2024-39249.Dependency updates with no impacts to pa11y-ci
cheeriofrom 1.0.0-rc.12 to 1.0.0.DevDependency updates with no impacts to pa11y-ci
eslintfrom 8.56.0 to 8.57.1.eslint@9which requires an update topa11y-lint-config(althougheslint@8is now deprecated).mochafrom 10.3.0 to 11.1.0.nycfrom 15.1.0 to 17.1.0.sinonfrom 17.0.1 to 20.0.0.Bug Fixes
bin/pa11y-ci.jsto callprocess.exit()with exit code instead of setting it withprocess.exitCode. This closes Pa11y CI hangs when passing browser/page in config #248.CI Updates
publishworkflow to publish with provenance.lintandpublishCI jobs to Node 22 and updateactions/setup-nodefrom v3 to v4.teststest matrix to current supported Node releases (20/22/24, which matches[email protected]), and with changes required to open Chrome for Testing in Ubuntu 24.04, which is transitioning toubuntu-latest.Other miscellaneous updates
.npmrc, which was only pinning the lockfile to version 2. All currently supported versions of Node.js support lockfile version 3..nvmrc, which was set to Node 18, and also for consistency withpa11y.Closes #227, closes #198, closes #247 (I believe).
Supersedes #242