-
Notifications
You must be signed in to change notification settings - Fork 6
chore(deps): bump k8slibs to v0.33.3 and controller-runtime to v0.21.0 #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 45.81% 44.99% -0.83%
==========================================
Files 27 27
Lines 2916 2916
==========================================
- Hits 1336 1312 -24
- Misses 1476 1500 +24
Partials 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - Thanks!
I pointed out a small nit and expressed my confusion about the linter.
Good stuff!
We'll merge this after we've fixed another bug.
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Co-authored-by: Todd Short <[email protected]>
Summary
Closes #190 #220 #221 #222 #223
NOTE:
t.Context()
cannot be used insidet.Cleanup
. Therefore, I had to do some //nolint:usetesting and use context.Background() in some places.Change Type
Dependency update
Check List Before Merging
Additional Information