Skip to content

chore(deps): bump k8slibs to v0.33.3 and controller-runtime to v0.21.0 #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

perdasilva
Copy link

@perdasilva perdasilva commented Jul 15, 2025

Summary

Closes #190 #220 #221 #222 #223

  • Bumps kube and controller-runtime dependency versions (brings go version bump to go1.24)
  • Refactors managedcache for breaking change coming from controller-runtime
  • Refactors tests to use t.Context() where possible (lint complaint)
  • Bumps go version in CI GHA

NOTE: t.Context() cannot be used inside t.Cleanup. Therefore, I had to do some //nolint:usetesting and use context.Background() in some places.

Change Type

Dependency update

Check List Before Merging

  • This PR passes all pre-commit hook validations.
  • This PR is fully tested and regression tests are included.
  • Relevant documentation has been updated.

Additional Information

@perdasilva perdasilva changed the title Refactors managedcache for breaking controller-runtime changes Update and refactor for k8s and controller-runtime libs Jul 15, 2025
@perdasilva perdasilva marked this pull request as draft July 15, 2025 08:47
@perdasilva perdasilva marked this pull request as ready for review July 15, 2025 09:38
@perdasilva perdasilva changed the title Update and refactor for k8s and controller-runtime libs chore(deps): bump k8slibs to v0.33.0 and controller-runtime to v0.21.0 Jul 15, 2025
@perdasilva perdasilva changed the title chore(deps): bump k8slibs to v0.33.0 and controller-runtime to v0.21.0 chore(deps): bump k8slibs to v0.33.2 and controller-runtime to v0.21.0 Jul 15, 2025
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.99%. Comparing base (ae7fc35) to head (f55c20a).

Files with missing lines Patch % Lines
managedcache/trackingcache.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   45.81%   44.99%   -0.83%     
==========================================
  Files          27       27              
  Lines        2916     2916              
==========================================
- Hits         1336     1312      -24     
- Misses       1476     1500      +24     
  Partials      104      104              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@erdii erdii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - Thanks!
I pointed out a small nit and expressed my confusion about the linter.

Good stuff!
We'll merge this after we've fixed another bug.

@erdii
Copy link
Member

erdii commented Jul 15, 2025

image

These conflicts don't have to be fixed here. We have temporarily removed the file and will re-introduce it again before merging this PR.

Per Goncalves da Silva added 4 commits July 21, 2025 18:15
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva changed the title chore(deps): bump k8slibs to v0.33.2 and controller-runtime to v0.21.0 chore(deps): bump k8slibs to v0.33.3 and controller-runtime to v0.21.0 Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants