PKO-305: re-add fixed enqueue watching #225
Open
+670
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdii
changed the title
erdii
force-pushed
the
readd-enqueue-watching
branch
4 times, most recently
from
1333268 to
c521e84
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 45.81% 54.08% +8.27%
==========================================
Files 27 28 +1
Lines 2916 3021 +105
==========================================
+ Hits 1336 1634 +298
+ Misses 1476 1257 -219
- Partials 104 130 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pbabic-redhat
suggested changes
Jul 28, 2025
managedcache/enqueue_watching.go
Outdated
Comment on lines
92
to
93
| // TODO: error reporting? | ||
| panic(err) |
There was a problem hiding this comment.
Add fmt.Sprintf to the panic with object info.
Comment on lines
+119
to
+126
| for i := range owned { | ||
| j := len(owned) - i | ||
| objects := owned[:j] |
…hes and starts/stops multiple informers for each cache Signed-off-by: Josh Gwosdz <[email protected]>
Signed-off-by: Josh Gwosdz <[email protected]>
Signed-off-by: Josh Gwosdz <[email protected]>
Signed-off-by: Josh Gwosdz <[email protected]>
…to make the accessmanager mockable Signed-off-by: Josh Gwosdz <[email protected]>
…ature by passing sets.Set directly without intermediate conversion to a slice
erdii
force-pushed
the
readd-enqueue-watching
branch
from
5776d87 to
21a3868
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PKO-305: https://issues.redhat.com/browse/PKO-305
This PR re-introduces the enqueue watching cache source feature.
I've added some fixes and simplifications on top.
Change Type
New Feature
Bug Fix
Check List Before Merging
Additional Information