fix: Apply chmod to tmpfile, not the outfile #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweinelt
force-pushed
the
chmod-tmpfile
branch
from
0f50f9d to
19829a6
Compare
This was missed during review, so the permissions are now too narrow. Signed-off-by: Martin Weinelt <[email protected]>
mweinelt
force-pushed
the
chmod-tmpfile
branch
from
19829a6 to
41977f1
Compare
mweinelt
changed the title
Contributor
Author
|
@displague @t0mk PTAL We're running it like that in production and it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed during review, so the permissions are now too narrow.
Tested and the permissions are now correct.