Skip to content
This repository has been archived by the owner on Mar 9, 2020. It is now read-only.

[Security] Bump handlebars from 4.0.11 to 4.1.0 #365

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Feb 14, 2019

Bumps handlebars from 4.0.11 to 4.1.0. This update includes security fixes.

Vulnerabilities fixed

Sourced from The npm Advisory Database.

Prototype Pollusion
All versions of handlebars are vulnerable to Prototype Pollusion. Templates may alter an Objects' prototype, thus allowing an attacker to execute arbitrary code on the server.

Affected versions: <=4.0.12

Changelog

Sourced from handlebars's changelog.

v4.1.0 - February 7th, 2019

New Features

  • import TypeScript typings - 27ac1ee

Security fixes:

  • disallow access to the constructor in templates to prevent RCE - 42841c4, #1495

Housekeeping

  • chore: fix components/handlebars package.json and auto-update on release - bacd473
  • chore: Use node 10 to build handlebars - 78dd89c
  • chore/doc: Add more release docs - 6b87c21

Compatibility notes:

Access to class constructors (i.e. ({}).constructor) is now prohibited to prevent
Remote Code Execution. This means that following construct will no work anymore:

class SomeClass {
}

SomeClass.staticProperty = 'static'

var template = Handlebars.compile('{{constructor.staticProperty}}');
document.getElementById('output').innerHTML = template(new SomeClass());
// expected: 'static', but now this is empty.

This kind of access is not the intended use of Handlebars and leads to the vulnerability described in #1495. We will not increase the major version, because such use is not intended or documented, and because of the potential impact of the issue (we fear that most people won't use a new major version and the issue may not be resolved on many systems).

Commits

v4.0.12 - September 4th, 2018

New features:

  • none

Various dependency updates

  • #1464 - Bump versions of grunt-plugins to 1.x
  • #1398 - Chore: updated various dev dependencies
  • upgrade uglify-js - d3d3942
  • Update grunt-eslint to 20.1.0 - 7729aa9
  • Update dependencies "async" to 2.5.0 and "source-map" to 0.6.1 (73d5637)
... (truncated)
Commits
  • 7caca94 v4.1.0
  • 7bd34fb Update release notes
  • 56fc676 test: run appveyor tests in Node 10
  • ee30222 chore: disable sauce-labs
  • 05e6293 chore: bump version of grunt-saucelabs
  • 2db0d12 chore: add .idea and yarn-error.log to .gitignore
  • edc6220 fix: disallow access to the constructor in templates to prevent RCE
  • bacd473 chore: fix components/handlebars package.json and auto-update on release
  • 27ac1ee Feat: Import TypeScript typings
  • 78dd89c chore: Use node 10 to build handlebars
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added dependencies security Pull requests that address a security vulnerability labels Feb 14, 2019
@digitalcitizenship
Copy link

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #365 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files          42       42           
  Lines        1915     1915           
  Branches      217      217           
=======================================
  Hits         1755     1755           
  Misses        155      155           
  Partials        5        5

1 similar comment
@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #365 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files          42       42           
  Lines        1915     1915           
  Branches      217      217           
=======================================
  Hits         1755     1755           
  Misses        155      155           
  Partials        5        5

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #365 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files          10       10           
  Lines         981      981           
  Branches      132      131    -1     
=======================================
  Hits          897      897           
  Misses         80       80           
  Partials        4        4

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/handlebars-4.1.0 branch from 056d322 to 8b370de Compare March 25, 2019 04:28
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/handlebars-4.1.0 branch from 8b370de to c327852 Compare May 27, 2019 04:15
@dependabot-preview dependabot-preview bot requested a review from cloudify as a code owner May 27, 2019 04:15
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/handlebars-4.1.0 branch from c327852 to 6e38f53 Compare June 24, 2019 04:17
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/handlebars-4.1.0 branch from 6e38f53 to 39f3536 Compare July 8, 2019 04:16
@dependabot-preview
Copy link
Contributor Author

Superseded by #430.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/handlebars-4.1.0 branch December 26, 2019 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies security Pull requests that address a security vulnerability
Development

Successfully merging this pull request may close these issues.

1 participant