PIN-6482 Add check on user role on bff for upload document #2177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrotaje
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
taglioni-r
approved these changes
Jul 24, 2025
AsterITA
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pagopa.atlassian.net/browse/PIN-6482
The bug is generated by applying visibility to eservice or eservice templates on
getEserviceByIdorgetEServiceTemplateByIdthat returns 404 if for your role is not possible to view that eservice/eserviceTemplate.Since this specific endpoint contains some logic and performs some actions, even uploading a file, I added the authorization check also here so that the endpoint returns 403 before accessing the logic of the service.