Skip to content

PIN-7280 - APIV2 GET /producerKeychains and GET /producerKeychains/{keychainId} #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: pin-7238_refactor-producer-keychain-visibility
Choose a base branch
from

Conversation

Carminepo2
Copy link
Contributor

@Carminepo2 Carminepo2 commented Jul 24, 2025

Merge after #2191
Closes PIN-7280
Closes PIN-7330

SRS

Description

Implemented GET /producerKeychains and GET /producerKeychains/{keychainId} routes in m2m gateway

Implementation

  • Finalize SRS
  • JIRA task link in PR, with link to SRS
  • API spec of the route in m2mGatewayApi.yml
  • Documentation: description fields in the spec endpoint, response, errors, params, etc.

Double-check errors

  • Check errors returned by the process API calls (messages should be meaningful, clean, in correct English, etc.)
  • Check spec errors: it should list all non-500 errors, also the ones that pass through from the process

Testing

Checklist:

  • Bruno call added to collection
  • Smoke test Bruno (attach result screenshot)
  • [] Supertest /api tests
  • /integration tests for the logic in the service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant