Skip to content

Pin 7341 pin 7342 tenant add revoke verified declared attributes #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

crasherbit
Copy link
Collaborator

Description

SRS-7341
SRS-7342

add tenant verifiedAttribute – POST /tenants/{tenantId}/verifiedAttributes/{attributeId}
revoke tenant verifiedAttribute – DELETE /tenants/{tenantId}/verifiedAttributes/{attributeId}

add tenant declaredAttribute – POST /tenants/{tenantId}/declaredAttributes/{attributeId}
revoke tenant declaredAttribute – DELETE /tenants/{tenantId}/declaredAttributes/{attributeId}

Implementation

  • [] Finalize SRS
  • [] JIRA task link in PR, with link to SRS
  • [] API spec of the route in m2mGatewayApi.yml
  • [] Documentation: description fields in the spec endpoint, response, errors, params, etc.

Double-check errors

  • Check errors returned by the process API calls (messages should be meaningful, clean, in correct English, etc.)
  • Check spec errors: it should list all non-500 errors, also the ones that pass through from the process

Testing

Checklist:

  • Bruno call added to collection
  • Smoke test Bruno (attach result screenshot)
  • [] Supertest /api tests
  • [] /integration tests for the logic in the service

Bruno screen

Crasherbit and others added 7 commits July 21, 2025 15:33
- Implemented `addDeclaredAttribute` and `revokeDeclaredAttribute` methods in tenantService for managing declared attributes.
- Implemented `addVerifiedAttribute` and `revokeVerifiedAttribute` methods in tenantService for managing verified attributes.
- Added error handling for attribute management operations with specific error mappers.
- Created unit tests for the new attribute management functions, covering success and error scenarios.
- Added integration tests for declared and verified attribute management to ensure proper functionality with the backend.
- Updated mock utilities to support new context requirements for tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant