feat(SegmentedControl): allow for passing stricter type for options #7051

bvandercar-vt · 2024-11-07T19:01:47Z

Checklist

[N/A] Includes tests
Update documentation

Changes proposed in this pull request:

Allow for stricter type on SegmentedControl than just string, which reduces the need for type casting in many cases (such as onChange call).

For example, you can still have just

<SegmentedControl

as before, for general string Options, or you can have

<SegmentedControl<OptionsEnum>

to make sure that all passed option values, and the onChange, have the OptionsEnum type.

Reviewers should focus on:

Improved type casting abilities, and mainly, the reduction of having to type cast.

Screenshot

No visual changes.

changelog-app · 2024-11-07T19:01:52Z

Generate changelog in `packages/core/changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

feat(SegmentedControl): allow for passing stricter type for options

Generate changelog in `packages/docs-app/changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

feat(SegmentedControl): allow for passing stricter type for options

Check the box to generate changelog(s)

Generate changelog entry

jscheiny · 2024-11-13T14:40:04Z

packages/core/src/components/segmented-control/segmentedControl.tsx


+// This allows the ability to pass a more strict type for `options`/`onValueChange`
+// i.e. <SegmentedControl<Intent> />
+interface ReactFCWithGeneric extends React.FC<SegmentedControlProps> {


Nit this is a specific interface for SegmentedControl so lets name it something in accordance with that.

Suggested change

interface ReactFCWithGeneric extends React.FC<SegmentedControlProps> {

interface GenericSegmentedControl extends React.FC<SegmentedControlProps> {

Renamed and commented to match the other cases.

jscheiny · 2024-11-13T14:42:39Z

packages/docs-app/src/examples/core-examples/common/sizeSelect.tsx

-};
+export const SizeSelect: React.FC<SizeSelectProps> = ({ label, size, optionLabels, onChange }) => (
+    <FormGroup label={label}>
+        <SegmentedControl<Size>


Out of curiosity, in these types of cases if you omit <Size> is the generic type parameter properly inferred from the options array? I'm guessing not because there's no as const.

I'm guessing not because there's no as const.

Correct, it can't be inferred from the options in that case. But it is inferred from the type of the value prop.

jscheiny · 2024-11-13T14:43:50Z

packages/docs-app/src/examples/core-examples/common/sizeSelect.tsx

+                { label: optionLabels[1], value: "regular" },
+                { label: optionLabels[2], value: "large" },
+            ]}
+            onValueChange={onChange}


Another point of curiosity (since we ran into this issue with another generic component recently), if you provide an arrow function here, does the type of the argument get properly inferred?

Yes.

If you specify a type in the generic, it will make sure the onChange arg has the proper type`.

If you don't specify a generic, the arrow function argument is just string

bvandercar-vt · 2025-02-19T02:00:59Z

@ggdouglas @jscheiny -- rebased this one.

bvandercar-vt · 2025-07-31T14:46:26Z

Going to replace with a newer PR.

bvandercar-vt mentioned this pull request Nov 7, 2024

feat(SegmentedControl): allow for passing stricter type for options #7050

Closed

1 task

ashleighp13 requested a review from jscheiny November 12, 2024 23:42

ashleighp13 assigned jscheiny Nov 12, 2024

jscheiny reviewed Nov 13, 2024

View reviewed changes

bvandercar-vt force-pushed the bvandercar/segmentedcontrol-value-types branch 4 times, most recently from 9fe373b to 92d2661 Compare January 27, 2025 23:38

bvandercar-vt force-pushed the bvandercar/segmentedcontrol-value-types branch from 6eb66b1 to ad256bb Compare February 19, 2025 02:02

bvandercar-vt force-pushed the bvandercar/segmentedcontrol-value-types branch from 497943c to bc3e966 Compare March 6, 2025 14:51

feat(SegmentedControl): allow for passing stricter type for options

0eefcda

bvandercar-vt force-pushed the bvandercar/segmentedcontrol-value-types branch from 199ce78 to 0eefcda Compare March 6, 2025 14:53

bvandercar-vt added 4 commits April 8, 2025 12:59

Merge branch 'develop' into bvandercar/segmentedcontrol-value-types

eb783cc

revert

87bed3d

Merge branch 'develop' into bvandercar/segmentedcontrol-value-types

2a4981f

lint fix

0ee3c54

ggdouglas unassigned jscheiny May 27, 2025

bvandercar-vt added 4 commits July 25, 2025 11:39

Merge branch 'develop' into bvandercar/segmentedcontrol-value-types

20bdfa0

lint fix

d922d8d

update for refactor

1f56506

com

efddcc5

bvandercar-vt closed this Jul 31, 2025

bvandercar-vt deleted the bvandercar/segmentedcontrol-value-types branch July 31, 2025 14:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(SegmentedControl): allow for passing stricter type for options #7051

feat(SegmentedControl): allow for passing stricter type for options #7051

Uh oh!

bvandercar-vt commented Nov 7, 2024

Uh oh!

changelog-app bot commented Nov 7, 2024

Uh oh!

jscheiny Nov 13, 2024

Uh oh!

bvandercar-vt Nov 13, 2024

Uh oh!

bvandercar-vt Jan 27, 2025

Uh oh!

jscheiny Nov 13, 2024

Uh oh!

bvandercar-vt Nov 13, 2024 •

edited

Loading

Uh oh!

jscheiny Nov 13, 2024

Uh oh!

bvandercar-vt Nov 13, 2024 •

edited

Loading

Uh oh!

bvandercar-vt commented Feb 19, 2025

Uh oh!

bvandercar-vt commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	interface ReactFCWithGeneric extends React.FC<SegmentedControlProps> {
	interface GenericSegmentedControl extends React.FC<SegmentedControlProps> {

feat(SegmentedControl): allow for passing stricter type for options #7051

feat(SegmentedControl): allow for passing stricter type for options #7051

Uh oh!

Conversation

bvandercar-vt commented Nov 7, 2024

Checklist

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Uh oh!

changelog-app bot commented Nov 7, 2024

Generate changelog in packages/core/changelog/@unreleased

Generate changelog in packages/docs-app/changelog/@unreleased

Uh oh!

jscheiny Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

bvandercar-vt Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

bvandercar-vt Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

jscheiny Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

bvandercar-vt Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jscheiny Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

bvandercar-vt Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bvandercar-vt commented Feb 19, 2025

Uh oh!

bvandercar-vt commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Generate changelog in `packages/core/changelog/@unreleased`

Generate changelog in `packages/docs-app/changelog/@unreleased`

bvandercar-vt Nov 13, 2024 •

edited

Loading

bvandercar-vt Nov 13, 2024 •

edited

Loading