Skip to content

[chore] Refactor Dialog to a functional component #7438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ggdouglas
Copy link
Contributor

@ggdouglas ggdouglas commented Apr 14, 2025

Refactors <Dialog> from a class-based to a functional component.

Before | After

Part of:

Supersedes:

@svc-palantir-github
Copy link

Refactor Dialog to be a functional component

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Fix up type in Dialog tests

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas force-pushed the gdouglas/refactor-dialog-fc branch 2 times, most recently from 8506fdb to ed76cea Compare April 15, 2025 18:34
@svc-palantir-github
Copy link

Refactor dialog tests to use RTL

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas force-pushed the gdouglas/refactor-dialog-fc branch from ed76cea to befeb4f Compare July 25, 2025 19:41
@svc-palantir-github
Copy link

Refactor dialog tests to use RTL

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas force-pushed the gdouglas/refactor-dialog-fc branch from befeb4f to 00f725b Compare July 25, 2025 19:56
@ggdouglas ggdouglas force-pushed the gdouglas/refactor-dialog-fc branch from 00f725b to 7e17a69 Compare July 25, 2025 19:57
@svc-palantir-github
Copy link

Refactor dialog tests to use RTL

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants