Skip to content

[Demo] Explore replacing Popper v2 with Floating UI #7507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 25 commits into
base: develop
Choose a base branch
from

Conversation

ggdouglas
Copy link
Contributor

  • [demo] (temp) Add demo code to demo-app
  • Attempt to migrate Popover to PopoverFloating
  • [demo] Replace Popover with PopoverFloating in examples
  • [demo] Replace Popover with PopoverFloating in components
  • Allow update() function to be called from outside of PopoverFloating
  • Modifiers
  • Auto placement

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

It's currently broken and causing issues when viewing the docs.
@svc-palantir-github
Copy link

Lint and fix circular dependency issues

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Fix `canEscapeKeyClose` bug

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Refactor arrow positioning in PopoverPopup to use cssPropertyToString for improved value handling

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Fix references in popover tests

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants