Skip to content

Conversation

@rallelind
Copy link
Contributor

Fixes #6695

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Instead of having the value of the option typed as a string, it should be a generic so that one could pass a enum for example.

Reviewers should focus on:

I did not change the documentation as the documentation still holds for this change. Maybe it should include this, i was not sure?
I would like focus on the wrapping around the forwardRef as it was a bit annoying to get the generic types to work there, the way i ended up doing it seemed to me the cleanest, but maybe there is a better way. Furthermore i added a comment that when/if this repo gets updated to React 19 then it should make it way easier as forwardRef is deprecated there.

@changelog-app
Copy link

changelog-app bot commented Nov 20, 2025

Generate changelog in packages/core/changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

Add generically typed options to

Check the box to generate changelog(s)

  • Generate changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generically typed selection UI

1 participant