Add metric for table size relative to storage load #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inespot
reviewed
Apr 9, 2025
| @@ -453,6 +455,9 @@ public Long getValue() | |||
| } | |||
| }); | |||
| liveDiskSpaceUsed = createColumnFamilyCounter("LiveDiskSpaceUsed"); | |||
| liveDiskSpaceUsedRatio = Metrics.register( | |||
| factory.createMetricName("LiveDiskSpaceUsedRatio"), | |||
| () -> (double) liveDiskSpaceUsed.getCount() / StorageMetrics.load.getCount()); | |||
There was a problem hiding this comment.
I think this might be the supported way of doing this:
cassandra/src/java/org/apache/cassandra/metrics/CacheMetrics.java
Lines 66 to 73 in 8896a70
There was a problem hiding this comment.
Nice find, I've implemented that same pattern!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a metric for a columnfamily's storage load relative to global storage load. This will help establish tables that are so large that we might no longer be able to compact them if we are also running short on disk space.