improvement: Implement round robin scorer as URISelector interface #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-runtime into dt/round-robin-scorer
dtrejod
force-pushed
the
dt/round-robin-scorer
branch
from
74ef7fa to
8ac8585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Referencing the new URIScorer interface from #349, we add a implementation of the URIScorer for the round robin URI scoring algorithm. Round robin as of recently was the default algo for selecting URIs. It's implementation was subtle within the request retrier seen here:
conjure-go-runtime/conjure-go-client/httpclient/internal/request_retrier.go
Line 156 in 5af5fa9
After this PR
==COMMIT_MSG==
Implement round robin scorer as URISelector interface
==COMMIT_MSG==
Possible downsides?
This change is