wip: add refreshable *tls.Config param support #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
sidkmenon
commented
Feb 14, 2025
| return clientOrHTTPClientParamFunc(func(b *httpClientBuilder) error { | ||
| b.TLSConfig = m | ||
| return nil | ||
| }), m.Update |
There was a problem hiding this comment.
for this, the clients would be responsible for calling updateFn whenever they want to refresh the underlying *tls.Config of their clients.
sidkmenon
force-pushed
the
sm/update_fn_alt
branch
from
3e34392 to
b6bf1c5
Compare
bmoylan
reviewed
Apr 1, 2025
| @@ -61,14 +71,14 @@ func ConfigureTransport(r RefreshableTransportParams, mapFn func(p TransportPara | |||
| // RefreshableTransport implements http.RoundTripper backed by a refreshable *http.Transport. | |||
| // The transport and internal dialer are each rebuilt when any of their respective parameters are updated. | |||
| type RefreshableTransport struct { | |||
| refreshable.Refreshable // contains *http.Transport | |||
| atomic.Pointer[http.Transport] | |||
bmoylan
reviewed
Apr 1, 2025
| } | ||
|
|
||
| type MappedRefreshableTLSConfig struct { | ||
| conf atomic.Pointer[tls.Config] |
There was a problem hiding this comment.
why are we reimplementing refreshable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Alternative impl to #725
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?