Reduce Optional allocations in SafetyEvaluator #2433
+40
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
This SafetyEvaluator class allocates Optional objects on its hot path and this allocation shows up in JFRs of the gradle daemon in a large internal project.
After this PR
==COMMIT_MSG==
Reduce Optional allocations in SafetyEvaluator
==COMMIT_MSG==
This PR reduces Optional allocation by two techniques:
Together, these save significant amounts of allocation, ~65% of 3GiB => ~2GiB by my reading of this JFR screenshots.
See 3 screenshots (large so not including inline):
Possible downsides?
Preconditions.checkNotNull
would fail fast if there was a missing entry of the table. The previous logic is used unchanged, just with this caching table in front.