Replace educe with a custom derive macro #508
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Conjure-defined types using
f64need to implement traits that they would not normally be able to using Rust's built-in derive. We previously used theeducecrate to be able to customize the behavior of fields containingf64. However, educe is unmaintained and has some significant correctness issues.After this PR
==COMMIT_MSG==
Replaced educe with a custom derive macro.
==COMMIT_MSG==
To minimize the complexity of the macro, we proxy the trait impls through a delegate type. This allows us to rely on Rust's built-in derive logic for all of the heavy codegen lifting:
Possible downsides?
The conversions through the delegate type may make these trait implementations slower.
Since the derive is only intended for use by conjure_codegen, the implementation cuts some corners. For example, it doesn't work on any generic types.