Skip to content

Conversation

@bjlaub
Copy link
Contributor

@bjlaub bjlaub commented Jul 29, 2025

Before this PR

After this PR

==COMMIT_MSG==

==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Jul 29, 2025

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

Check the box to generate changelog(s)

  • Generate changelog entry


Optional<ExecutorService> blockingExecutor();

@Value.Default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need access to this value in ConjureRuntime so I'm able to use it in generated code.

The generated Dialogue services have a factory method providing two arguments: an EndpointChannelFactory (which is an interface with a method providing an EndpointChannel, and ConjureRuntime.

@stale
Copy link

stale bot commented Oct 18, 2025

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants