Second round of the benchmarks #1036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericanderson
force-pushed
the
ea.benchmark2
branch
4 times, most recently
from
ff3b3b1 to
c6364c6
Compare
ericanderson
force-pushed
the
ea.benchmark2
branch
from
e06eb75 to
20a0e4c
Compare
| } | ||
| import { createPublicOauthClient } from "@osdk/oauth"; | ||
|
|
||
| export { createPublicOauthClient }; |
There was a problem hiding this comment.
Why is this needed?(here and client)
nihalbhatnagar
previously approved these changes
Dec 6, 2024
* origin/main: Add typed lint checks and fix promise related things (#1081) Version Packages (beta) (#1090) Export hydrateObjectSetFromRid from internal (#1087) Fetch by RID experimental (#1088) Creates new internal export for helper methods we want to hide (#1084) Add's more descriptive error messages for 429 errors and other errors with no body (#1082) Update react template per discussion (#1077) OSDK client internal property is hidden from output .d.ts (#1079) Revert `api:x-read/write` back to `api:read/write-x` (#1076) Move from "views" naming to "widgets" (#1075) Fixes attachment uploads in Browser context (#1064) Use foundry-config-json in widget-manifest-vite-plugin (#1055) Version Packages (beta) (#1072) Ignore unknown types (#1067) Correct widget template package dependency versions (#1068) Make interface type status configurable (#1069) Fix onOutOfDate handler from firing twice (#1071) Rename @osdk/widget-manifest-vite-plugin to @osdk/widget.vite-plugin.unstable (#1065) Fixing main (#1066) Add structs read support (#1047) Handle Vite plugin injections in Custom Widget Vite plugin (#1063) Version Packages (beta) (#1060) Fix unused import (#1061) Revive eslint-plugin-unused-imports (#1057) Fix URL for getBulkLinks (#1058) Split foundry-config-json package (#1054) Add package.json auto version strategy (#1052) Remove crypto from OSDK (#1051) Support site snapshot upload (#1049) Try catch subscription handlers (#1019) Experiment with no proxy for objects (#1031) Bump unstable widget packages to v1 to avoid undesired v0.x version behavior (#1050) WeakRef the as()'d objects (#1043)
policy-bot
bot
dismissed
nihalbhatnagar’s stale review
Invalidated by push of 354b548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One benchmark per package
After adding a few benchmarks, having one package got annoying because some of them took a long time and you may not always want to run all of them.
This breaks everything up into independent libraries / packages so you can iterate better.
Serial and Parallel
This also introduces the concept of serial and parallel benchmarks. Be sure to
turbo benchmark-serial --concurrency 1when you run those. Sadly we can't tell turbo that certain tasks are serial.In a future update we can potentially fix this.
Bundle Benchmarks
I want to be able to see what the output size of our work is across builds. I've started this with
createClientandcreatePublicOauthClient.FUTURE
It would be nice to have a comment like
/runBenchmarkstrigger a benchmark build. This build could potentially run on main and in the repo to compare the results.It would also be good if we start persisting the bundle file sizes for every build so we can track that.