fix ToDo sample to allow build on lesson level #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeyadkhaled
previously approved these changes
Jan 10, 2025
Comment on lines
+23
to
+34
| const { data, isLoading, isValidating, error, mutate } = useSWR<IProject[]>( | ||
| "projects", | ||
| async () => { | ||
| // Try to implement this with the Ontology SDK! | ||
| const projectsList: IProject[] = (await Mocks.getProjects()).map(( | ||
| project, | ||
| ) => ({ | ||
| ...project, | ||
| })); | ||
| return projectsList; | ||
| }, | ||
| ); |
There was a problem hiding this comment.
This feels like its redundant and could be done like this?
Suggested change
| const { data, isLoading, isValidating, error, mutate } = useSWR<IProject[]>( | |
| "projects", | |
| async () => { | |
| // Try to implement this with the Ontology SDK! | |
| const projectsList: IProject[] = (await Mocks.getProjects()).map(( | |
| project, | |
| ) => ({ | |
| ...project, | |
| })); | |
| return projectsList; | |
| }, | |
| ); | |
| const { data, isLoading, isValidating, error, mutate } = useSWR<IProject[]>( | |
| "projects", | |
| async () => { | |
| // Try to implement this with the Ontology SDK! | |
| const projectsList: IProject[] = await Mocks.getProjects(); | |
| return projectsList; | |
| }, | |
| ); |
There was a problem hiding this comment.
Right, but I thought it would be good to keep the mapping code here as when you implement the lesson you need a similar thing to map from your OSDK object to IProject.
| description: string; | ||
| } | ||
|
|
||
| export interface ITask { |
There was a problem hiding this comment.
This should live in useProjectTasks
policy-bot
bot
dismissed
zeyadkhaled’s stale review
Invalidated by push of fd91669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToDo tutorial on version 2.0 fails to build when you complete only lesson 1 out of the 2-3 lessons. This is due to type mismatch with the mock objects.
When users are using VS code in platform and check in the code the CI will fail as it run
npm run build, which is a poor experience.This PR extract the dependency of most of the code from the Mock objects so you can implement each method at a time and code will still compile. This PR will go together with a forge pr to fix the suggested solutions to the lessons.