Interface support in actions #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssanjay1
commented
Jan 10, 2025
packages/api/src/actions/Actions.ts
Outdated
| * Helper type to convert action definition parameter interface types to typescript types | ||
| */ | ||
| export type InterfaceType<T extends InterfaceDefinition> = { | ||
| $objectType: string; |
There was a problem hiding this comment.
So, we now get a list of objects that implement an interface that we theoretically could use to limit the object types you can pass in here. But, there's a chance that someone implements this interface with a new object type we won't know about after codegen
ericanderson
previously approved these changes
Jan 27, 2025
policy-bot
bot
dismissed
ericanderson’s stale review
Invalidated by push of 92fb73f
ericanderson
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actions can now take interface params