v0 for runtime derived properties #977
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihalbhatnagar
changed the title
nihalbhatnagar
commented
Nov 19, 2024
| D extends DeriveClause<K>, | ||
| > = { | ||
| __DefinitionMetadata: { | ||
| properties: { [T in Extract<keyof D, string>]: PropertyDef<"integer"> }; |
There was a problem hiding this comment.
PropertyDef<"integer"> : This is the fun part to figure out
nihalbhatnagar
commented
Nov 19, 2024
| @@ -245,4 +247,24 @@ export interface ObjectSet< | |||
| properties: Array<P>, | |||
| listener: EXPERIMENTAL_ObjectSetListener<Q, P>, | |||
| ) => { unsubscribe: () => void }; | |||
|
|
|||
| readonly derive: < | |||
There was a problem hiding this comment.
I'm not sure of the best way to gate this. I want this to be on object set since I want to ensure you can do stuff to an object set before it. Is it crazy to leave this ungated on beta(only merged when e2e works ofc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.