Skip to content

Conversation

@kelvinou01
Copy link
Contributor

Before this PR

After this PR

==COMMIT_MSG==
Add the -PerrorProneRemoveUnused flag to remove unused suppressions
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Sep 24, 2025

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

Add the -PerrorProneRemoveUnused flag to remove unused suppressions

Check the box to generate changelog(s)

  • Generate changelog entry

* Note that this will only delete the whitespace before the element if the entire element is removed
* (i.e. if the replacement text is null or empty).
*/
private static final class LineRemovingReplacementFix implements Fix {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to top-level class

* Note that this will only delete the whitespace before the element if the entire element is removed
* (i.e. if the replacement text is null or empty).
*/
public final class LineRemovingReplacementFix implements Fix {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing changed

@kelvinou01 kelvinou01 changed the title Add the -PerrorProneRemoveUnused flag to remove unused suppressions -PerrorProneRemoveUnused implementation: uses it's own separate check which runs all other checks Sep 29, 2025
@stale
Copy link

stale bot commented Oct 18, 2025

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants