KHP3-6550 - Added RMS integration for patient registration, bills and payments #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickWaweru
requested review from
patryllus,
ojwanganto,
makombe and
njorocs
ojwanganto
reviewed
Oct 4, 2024
| * @param date | ||
| * @return | ||
| */ | ||
| public static boolean checkIfCreateModetOrEditMode(Date date) { |
ojwanganto
reviewed
Oct 4, 2024
| .getGlobalPropertyObject(CashierModuleConstants.RMS_ENDPOINT_URL); | ||
| String baseURL = globalPostUrl.getPropertyValue(); | ||
| if (baseURL == null || baseURL.trim().isEmpty()) { | ||
| baseURL = "https://siaya.tsconect.com/api"; |
There was a problem hiding this comment.
this should probably be in a global property
ojwanganto
reviewed
Oct 4, 2024
| <globalProperty> | ||
| <property>${project.parent.artifactId}.rms.integration.username</property> | ||
| <description>RMS integration Username</description> | ||
| <defaultValue>[email protected]</defaultValue> |
ojwanganto
reviewed
Oct 4, 2024
| <globalProperty> | ||
| <property>${project.parent.artifactId}.rms.integration.endpoint.url</property> | ||
| <description>RMS integration Endpoint URL</description> | ||
| <defaultValue>https://siaya.tsconect.com/api</defaultValue> |
makombe
reviewed
Oct 7, 2024
There was a problem hiding this comment.
LGTM, @PatrickWaweru Please address some of the suggestions highlighted thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KHP3-6550 - siaya - RMS financial system sync